[Auto] Add unit tests for craftd-core#104
Closed
rviannaoliveira wants to merge 13 commits intomainfrom
Closed
Conversation
…ifacts Scoped change to Android/KMP only (iOS and Flutter out of scope). Generated proposal.md, design.md, specs/craftd-image/spec.md and tasks.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rule 11: every new component must have a working example in the corresponding sample app (app-sample-android for Compose and XML). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add section 6 with tasks to register and demonstrate CraftDImage in app-sample-android for both Compose and XML setups. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove PostToolUse/Edit hook and build-on-task-complete.sh. Add explicit rule: run ./gradlew build before marking task [x]. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Define parallel agent strategy in CLAUDE.md: core (sequential) → compose+xml (parallel) → docs/sample → revisor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add IMAGE_COMPONENT to CraftDComponentKey enum - Add CraftDContentScale enum (CROP, FIT, FILL_BOUNDS, FILL_WIDTH, FILL_HEIGHT, INSIDE, NONE) - Add ImageProperties data class with url, contentScale, contentDescription, actionProperties Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Compose: - Add toContentScale() extension mapping CraftDContentScale → ContentScale - Add CraftDImage composable with injectable imageLoader lambda - Add CraftDImageBuilder with injectable imageLoader constructor param XML: - Add CraftDImageComponent (AppCompatImageView wrapper) - Add CraftDImageComponentRender with injectable imageLoader - Register CraftDImageComponentRender in CraftDBuilderManager via optional imageLoader param Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Unit tests for ImageProperties serialization, toContentScale() and CraftDImageBuilder key - Updated docs/how-to-use/compose.md and view-system.md with CraftDImage usage examples - Registered CraftDImageBuilder (Coil) in Compose sample and CraftDImageComponentRender (Picasso) in XML sample - Added CraftDImage entry to dynamic.json - Switched app-sample-android to local craftd-xml project dependency - Added Coil 2.6.0 to libs.versions.toml - Deleted notes.md after context consumed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated Unit Tests
Este PR foi gerado automaticamente pelo workflow Auto Generate Cover+Test usando a Claude API.
Evolução de cobertura
Arquivos cobertos
Como funciona
android_kmp/craftd-coreChecklist de revisão
./gradlew testDebugUnitTest)